fix(customPropTypes|typings): allow to pass a function to itemShorthand, update typings #3183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSSIBLE BREAKING CHANGE
src/index.d.ts
was renamed tosrc/generic.d.ts
I hope that noone used it fromdist/commonjs/index.d.ts
because all types are reexported from the root. However I think that this thing should be noticed.Fixes and improvements
In feat(factories): support functions #2790 we introduced a small update to shorthands, however
customPropTypes.itemShorthand
wasn't updated. This PR does this. Fixes Pagination: Functions work for pageItem, etc. props, but warning is raised for invalid prop #3181.Typings were improved, you will get working autocomplete there 👍 It also satisfies
noImplicitAny
✌️